Re: [PATCH v3 16/23] trace-cmd: Add a new flag to disable any timestamp corrections

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 24 Mar 2021 10:24:24 -0400
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> On Wed, 24 Mar 2021 15:04:11 +0200
> "Tzvetomir Stoyanov (VMware)" <tz.stoyanov@xxxxxxxxx> wrote:
> 
> > @@ -2601,7 +2605,8 @@ static int handle_options(struct tracecmd_input *handle)
> >  			 * gtod. It is stored as ASCII with '0x'
> >  			 * appended.
> >  			 */
> > -			if (handle->flags & TRACECMD_FL_IGNORE_DATE)
> > +			if (handle->flags &
> > +			    (TRACECMD_FL_IGNORE_DATE || TRACECMD_FL_RAW_TS))  
> 
> Needs to be a binary 'or' "|", not a logical 'or' "||", as the above is the
> same as:  if (handle->flags & 1)
> 
> If I don't find anything else wrong in this series, I'll fix this myself.
> 

As I'm finding more things to fix, please do this update in your next
revision.

-- Steve



[Index of Archives]     [Linux USB Development]     [Linux USB Development]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux