Re: [PATCH] kernel-shark v2: Change the logic for opening trace-cmd files

"Yordan Karadzhov (VMware)" <y.karadz@xxxxxxxxx> · Thu, 11 Mar 2021 16:15:59 +0200

On 10.03.21 г. 23:48, Steven Rostedt wrote:

On Wed, 10 Mar 2021 14:11:35 +0200
"Tzvetomir Stoyanov (VMware)" <tz.stoyanov@xxxxxxxxx> wrote:

From: Tzvetomir (VMware)  Stoyanov <tz.stoyanov@xxxxxxxxx>

The logic for opening a trace file by trace-cmd library has changed.
Any timestamp corrections, found in the trace file metadata are applied
automatically. The old APIs, used by KernelShark for pairing trace files
from the same host-guest traceing session and adjusting timestamps are

  s/traceing/tracing/

now obsolete and should not be used.

Signed-off-by: Tzvetomir (VMware)  Stoyanov <tz.stoyanov@xxxxxxxxx>

The from and SOB should be Tzvetomir Stoyanov (VMware), unless you changed
your middle name to (VMware) ;-)

As for the rest of the patch.

Reviewed-by: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx>

Hi Steven,

Thanks a lot for the review!

Have you tested that this works with the Timestamp synchronization 

patches that are not upstreamed yet?

Thanks!
Yordan

-- Steve