On Wed, 24 Feb 2021 15:04:51 +0530 Sameeruddin Shaik <sameeruddin.shaik8@xxxxxxxxx> wrote: > hi, > > >I forgot to include you on the Cc for this email. > > Not a problem at all steve , bugzilla daemon sent me an update:) > > I have read your requirements, I am thinking to give 3 incremental > patches for this API > > patch-1 : will write normal strings into the filter file > patch-2: will handle the kernel glob expressions > patch-3: will handle the regular expressions Sure. You can send out a 3 patch set series and we can continue our discussion on that. > > >I think there should be a complementary API for deleting the filters, > >may be something like > >int tracefs_function_filter_remove(struct tracefs_instance *instance, > > const char * > > const *filters, > > const char *module) > > It should be able to remove the filters, configured by the first API > > with the same "filters, module" input parameters. > > Tzvetomir, > Let's wait for the steve inputs on this. I agree with Tzvetomir, but let's worry about the addition of filters API first, and then when we get that all settled out, we can add this one, as this one should be much simpler (famous last words). -- Steve
|