Re: [PATCH] trace-cmd: Add flags to APIs for opening trace file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri,  5 Feb 2021 09:56:38 +0200
"Tzvetomir Stoyanov (VMware)" <tz.stoyanov@xxxxxxxxx> wrote:

> +enum tracecmd_open_flags {
> +	TRACECMD_FLAG_LOAD_NO_PLUGINS		= 1 << 0, /* Do not load plugins */
> +	TRACECMD_FLAG_LOAD_NO_SYSTEM_PLUGINS	= 1 << 1, /* Do not load system plugins */
> +};

Small nit. It's been standard practice to use "_FL_" instead of "_FLAG_",
just to shorten the length of the name. That's also done in the Linux
kernel.

I can update this, if I don't find any other issues.

Thanks!

-- Steve




[Index of Archives]     [Linux USB Development]     [Linux USB Development]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux