On Thu, 4 Feb 2021 13:04:01 +0200 Tzvetomir Stoyanov <tz.stoyanov@xxxxxxxxx> wrote: > - Moving that logic out of tracecmd_alloc_fd() will break these APIs: > tracecmd_open() > tracecmd_open_fd() > tracecmd_open_head() Note, because libtracecmd has not been released yet, we still have the luxury of breaking its APIs ;-) > KernelShark relies on them for reading trace.dat files. We can think of > moving plugins loading in a separate API, which must be called at the > library initialisation phase, but this will require changes in the current > library users (KernelShark?). For libtracecmd, it is still OK to change the APIs even if KernelShark breaks. As the only KernelShark user is still in the trace-cmd repo, it should be OK. Once we have v2 out, then we need to have these APIs frozen. But until then, let's break the API if it makes it a better design. -- Steve
|