From: "Steven Rostedt (VMware)" <rostedt@xxxxxxxxxxx> The plist allocation check in get_trace_req_protos() returns error on a successful allocation. Fix it. Signed-off-by: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx> --- lib/trace-cmd/trace-msg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/trace-cmd/trace-msg.c b/lib/trace-cmd/trace-msg.c index 8d2ed38d..611af2c1 100644 --- a/lib/trace-cmd/trace-msg.c +++ b/lib/trace-cmd/trace-msg.c @@ -981,7 +981,7 @@ static int get_trace_req_protos(char *buf, int length, } plist = calloc(1, sizeof(struct tracecmd_tsync_protos)); - if (plist) + if (!plist) goto error; plist->names = calloc(count + 1, sizeof(char *)); if (!plist->names) -- 2.25.4