The file name input parameter of tracefs_instance_file_read() API should be a pointer to a constat string, as this file name must not be changed by the API. Signed-off-by: Tzvetomir Stoyanov (VMware) <tz.stoyanov@xxxxxxxxx> --- Documentation/libtracefs-instances-files.txt | 2 +- Documentation/libtracefs.txt | 2 +- include/tracefs.h | 2 +- src/tracefs-instance.c | 2 +- utest/tracefs-utest.c | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/Documentation/libtracefs-instances-files.txt b/Documentation/libtracefs-instances-files.txt index 9b18b73..a9af1f7 100644 --- a/Documentation/libtracefs-instances-files.txt +++ b/Documentation/libtracefs-instances-files.txt @@ -18,7 +18,7 @@ bool *tracefs_dir_exists*(struct tracefs_instance pass:[*]_instance_, char pass: char pass:[*]*tracefs_instance_get_file*(struct tracefs_instance pass:[*]_instance_, const char pass:[*]_file_); char pass:[*]*tracefs_instance_get_dir*(struct tracefs_instance pass:[*]_instance_); int *tracefs_instance_file_write*(struct tracefs_instance pass:[*]_instance_, const char pass:[*]_file_, const char pass:[*]_str_); -char pass:[*]*tracefs_instance_file_read*(struct tracefs_instance pass:[*]_instance_, char pass:[*]_file_, int pass:[*]_psize_); +char pass:[*]*tracefs_instance_file_read*(struct tracefs_instance pass:[*]_instance_, const char pass:[*]_file_, int pass:[*]_psize_); -- diff --git a/Documentation/libtracefs.txt b/Documentation/libtracefs.txt index ddbf783..bf3882f 100644 --- a/Documentation/libtracefs.txt +++ b/Documentation/libtracefs.txt @@ -26,7 +26,7 @@ Trace instances: char pass:[*]*tracefs_instance_get_file*(struct tracefs_instance pass:[*]_instance_, const char pass:[*]_file_); char pass:[*]*tracefs_instance_get_dir*(struct tracefs_instance pass:[*]_instance_); int *tracefs_instance_file_write*(struct tracefs_instance pass:[*]_instance_, const char pass:[*]_file_, const char pass:[*]_str_); - char pass:[*]*tracefs_instance_file_read*(struct tracefs_instance pass:[*]_instance_, char pass:[*]_file_, int pass:[*]_psize_); + char pass:[*]*tracefs_instance_file_read*(struct tracefs_instance pass:[*]_instance_, const char pass:[*]_file_, int pass:[*]_psize_); const char pass:[*]*tracefs_instance_get_name*(struct tracefs_instance pass:[*]_instance_); int *tracefs_instances_walk*(int (pass:[*]_callback_)(const char pass:[*], void pass:[*]), void pass:[*]_context)_; bool *tracefs_instance_exists*(const char pass:[*]_name_); diff --git a/include/tracefs.h b/include/tracefs.h index 3d70aca..06e2130 100644 --- a/include/tracefs.h +++ b/include/tracefs.h @@ -29,7 +29,7 @@ char *tracefs_instance_get_dir(struct tracefs_instance *instance); int tracefs_instance_file_write(struct tracefs_instance *instance, const char *file, const char *str); char *tracefs_instance_file_read(struct tracefs_instance *instance, - char *file, int *psize); + const char *file, int *psize); int tracefs_instances_walk(int (*callback)(const char *, void *), void *context); bool tracefs_instance_exists(const char *name); diff --git a/src/tracefs-instance.c b/src/tracefs-instance.c index bf3de7c..6dc85ee 100644 --- a/src/tracefs-instance.c +++ b/src/tracefs-instance.c @@ -282,7 +282,7 @@ int tracefs_instance_file_write(struct tracefs_instance *instance, * The return string must be freed by free() */ char *tracefs_instance_file_read(struct tracefs_instance *instance, - char *file, int *psize) + const char *file, int *psize) { char *buf = NULL; int size = 0; diff --git a/utest/tracefs-utest.c b/utest/tracefs-utest.c index b45a3c6..a8e8f67 100644 --- a/utest/tracefs-utest.c +++ b/utest/tracefs-utest.c @@ -181,7 +181,7 @@ static void test_trace_file(void) tracefs_put_tracing_file(file); } -static void test_instance_file_read(struct tracefs_instance *inst, char *fname) +static void test_instance_file_read(struct tracefs_instance *inst, const char *fname) { const char *tdir = tracefs_tracing_dir(); char buf[BUFSIZ]; -- 2.29.2