On Thu, 29 Oct 2020 13:18:06 +0200
"Tzvetomir Stoyanov (VMware)" <tz.stoyanov@xxxxxxxxx> wrote:
> Defined HOST and GUEST roles in timestamp synchronization context.
> Some timestamp synchronization plugins may not support running in both
> host and guest roles. This could happen in nested virtualization use
> case, where the same plugin can be used as a host and as a guest.
> Added logic to timestamp synchronization plugins to declare what roles
> they support. Added logic to select plugin depending on supported roles
> and currently requested role.
>
> clocks. Added logic to timestamp synchronization plugins to declare what
> ftace clocks they support. Added logic to select plugin depending on the
> ftrace clock used in the current trace session and supported clocks.
Extra paragraph?
>
> Signed-off-by: Tzvetomir Stoyanov (VMware) <tz.stoyanov@xxxxxxxxx>
> ---
> include/trace-cmd/trace-cmd.h | 10 ++++++++--
> lib/trace-cmd/include/trace-tsync-local.h | 2 +-
> lib/trace-cmd/trace-timesync.c | 17 ++++++++++++++---
> tracecmd/trace-record.c | 3 ++-
> tracecmd/trace-tsync.c | 3 ++-
> 5 files changed, 27 insertions(+), 8 deletions(-)
>
> diff --git a/include/trace-cmd/trace-cmd.h b/include/trace-cmd/trace-cmd.h
> index 21028940..1ca2da10 100644
> --- a/include/trace-cmd/trace-cmd.h
> +++ b/include/trace-cmd/trace-cmd.h
> @@ -437,6 +437,11 @@ enum{
> TRACECMD_TIME_SYNC_CMD_STOP = 2,
> };
>
> +enum tracecmd_time_sync_role {
> + TRACECMD_TIME_SYNC_ROLE_HOST = 0x01,
> + TRACECMD_TIME_SYNC_ROLE_GUEST = 0x02
If this is going to be used as a bitmask, it's best to demonstrate that
with:
(1 << 0),
(1 << 1)
-- Steve
> +};
> +
> struct tracecmd_time_sync {
> char *proto_name;
> int loop_interval;
|