Re: [PATCH] libtracefs: make it build against musl C library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed,  2 Dec 2020 06:08:02 +0200
"Tzvetomir Stoyanov (VMware)" <tz.stoyanov@xxxxxxxxx> wrote:

> From: Beniamin Sandu <beniaminsandu@xxxxxxxxx>
> 
> * add some missing headers and macros
> * set pthread affinity using pthread_setaffinity_np after creating the thread
> instead of pthread_attr_setaffinity_np (which seems to not be implemented
> in musl)
> 
> Tested using https://musl.cc/x86_64-linux-musl-native.tgz
> 
> Link: https://lore.kernel.org/linux-trace-devel/20201130122755.31000-1-beniaminsandu@xxxxxxxxx
> 
> Reviewed-by: Tzvetomir Stoyanov (VMware) <tz.stoyanov@xxxxxxxxx>
> Signed-off-by: Beniamin Sandu <beniaminsandu@xxxxxxxxx>
> [ Fixed a whitespace issue ]
> Signed-off-by: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx>

Tzvetomir,

FYI, when sending patches, even for those you are not the author for,
you are still required to add a Signed-off-by.

Please add that here, and I can pull it into the libtracefs repo.

Thanks!

-- Steve


> ---
>  include/tracefs-local.h | 12 ++++++++++++
>  tracefs-events.c        |  1 +
>  2 files changed, 13 insertions(+)
> 
> diff --git a/include/tracefs-local.h b/include/tracefs-local.h
> index 9cc371b..bdbf89e 100644
> --- a/include/tracefs-local.h
> +++ b/include/tracefs-local.h
> @@ -13,4 +13,16 @@ void warning(const char *fmt, ...);
>  int str_read_file(const char *file, char **buffer);
>  char *trace_append_file(const char *dir, const char *name);
>  
> +#ifndef ACCESSPERMS
> +#define ACCESSPERMS (S_IRWXU|S_IRWXG|S_IRWXO) /* 0777 */
> +#endif
> +
> +#ifndef ALLPERMS
> +#define ALLPERMS (S_ISUID|S_ISGID|S_ISVTX|S_IRWXU|S_IRWXG|S_IRWXO) /* 07777 */
> +#endif
> +
> +#ifndef DEFFILEMODE
> +#define DEFFILEMODE (S_IRUSR|S_IWUSR|S_IRGRP|S_IWGRP|S_IROTH|S_IWOTH) /* 0666*/
> +#endif
> +
>  #endif /* _TRACE_FS_LOCAL_H */
> diff --git a/tracefs-events.c b/tracefs-events.c
> index ca1d22b..ee45988 100644
> --- a/tracefs-events.c
> +++ b/tracefs-events.c
> @@ -13,6 +13,7 @@
>  #include <errno.h>
>  #include <sys/stat.h>
>  #include <fcntl.h>
> +#include <limits.h>
>  
>  #include <traceevent/kbuffer.h>
>  




[Index of Archives]     [Linux USB Development]     [Linux USB Development]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux