On Mon, Nov 23, 2020 at 8:50 PM Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
>
> From: "Steven Rostedt (VMware)" <rostedt@xxxxxxxxxxx>
>
> "make install" copies libtraceevent.pc.template to libtraceevent.pc and then
> modifies it for the installation. This command is usually executed as root,
> and when finished, it leaves behind the libtraceevent.pc file owned by root.
>
> Have the "make install" clean up and remove the temporary libtraceevent.pc
> file, so that root owned files do not get left behind.
Isn't it useful to have this file after the "make install" command, for debug
purposes - to see how exactly it was modified ? The file is removed by
"make clean".
>
> Signed-off-by: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx>
> ---
> Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Makefile b/Makefile
> index 2a6bfcce814f..775fbd2b3f0e 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -218,6 +218,7 @@ define do_install_pkgconfig_file
> sed -i "s|LIB_DIR|${libdir}|g" ${PKG_CONFIG_FILE}; \
> sed -i "s|HEADER_DIR|$(includedir)|g" ${PKG_CONFIG_FILE}; \
> $(call do_install,$(PKG_CONFIG_FILE),$(pkgconfig_dir),644); \
> + ${RM} ${PKG_CONFIG_FILE}; \
> else \
> (echo Failed to locate pkg-config directory) 1>&2; \
> fi
> --
> 2.28.0
>
>
--
Tzvetomir (Ceco) Stoyanov
VMware Open Source Technology Center
|