Re: [RFC PATCH] regmap: remove duplicate `type` field from `regcache_sync` trace event

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Nov 23, 2020 at 11:15:19AM -0500, Philippe Duplessis-Guindon wrote:

> 	$ sudo cat /sys/kernel/debug/tracing/events/regmap/regcache_sync/format
> 	name: regcache_sync
> 	ID: 1216
> 	format:

These dumps are very large, don't fit within 80 columns and it's quite
hard to figure out information they are intended to convey so they make
it quite hard to read your commit message.  Please just remove them if
they can't be made clear, I think the text is enough.

> 		field:__data_loc char[] type;	offset:16;	size:4;	signed:1;
> 		field:int type;    offset:20;    size:4;    signed:1;

> Erase the `int field` type, who was not assigned. This field was introduce by mistake and this commit removes it.

Please word wrap your commit message at less than 80 columns.

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux USB Development]     [Linux USB Development]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux