On Wed, 18 Nov 2020 16:49:49 +0200 "Yordan Karadzhov (VMware)" <y.karadz@xxxxxxxxx> wrote: > +static void *index_to_ptr(unsigned int index) > +{ > + unsigned long p; > + > + p = INVALID_STREAM_MASK | index; > + > + return (void *) p; I'm curious to why you add a space between the *) and the p? This is now your project, so I wont complain about formats like this. You can decide it. But typecasts in Linux are expected to be together with what they typecast. Again, no change required, we just need to be consistent with it. (makes it easier to grep for) -- Steve > +} > +