A new API is added to tracefs library: tracefs_get_clock() It reads the trace_clock file from the ftrace file system, parses it and returns a string with the current trace clock. The returned string must be freed by free(). Signed-off-by: Tzvetomir Stoyanov (VMware) <tz.stoyanov@xxxxxxxxx> --- include/tracefs/tracefs.h | 2 ++ lib/tracefs/tracefs-instance.c | 35 ++++++++++++++++++++++++++++++++++ tracecmd/trace-stat.c | 29 +++++++--------------------- 3 files changed, 44 insertions(+), 22 deletions(-) diff --git a/include/tracefs/tracefs.h b/include/tracefs/tracefs.h index 8ee7ba6e..fb33e6e8 100644 --- a/include/tracefs/tracefs.h +++ b/include/tracefs/tracefs.h @@ -55,4 +55,6 @@ struct tep_handle *tracefs_local_events_system(const char *tracing_dir, int tracefs_fill_local_events(const char *tracing_dir, struct tep_handle *tep, int *parsing_failures); +char *tracefs_get_clock(struct tracefs_instance *instance); + #endif /* _TRACE_FS_H */ diff --git a/lib/tracefs/tracefs-instance.c b/lib/tracefs/tracefs-instance.c index 50e88534..89d0b484 100644 --- a/lib/tracefs/tracefs-instance.c +++ b/lib/tracefs/tracefs-instance.c @@ -291,3 +291,38 @@ bool tracefs_dir_exists(struct tracefs_instance *instance, char *name) { return check_file_exists(instance, name, true); } + +/** + * tracefs_get_clock - Get the current trace clock + * @instance: ftrace instance, can be NULL for the top instance + * + * Returns the current trace clock of the given instance, or NULL in + * case of an error. + * The return string must be freed by free() + */ +char *tracefs_get_clock(struct tracefs_instance *instance) +{ + char *all_clocks = NULL; + char *ret = NULL; + int bytes = 0; + char *clock; + char *cont; + + all_clocks = tracefs_instance_file_read(instance, "trace_clock", &bytes); + if (!all_clocks || !bytes) + goto out; + + clock = strstr(all_clocks, "["); + if (!clock) + goto out; + clock++; + cont = strstr(clock, "]"); + if (!cont) + goto out; + *cont = '\0'; + + ret = strdup(clock); +out: + free(all_clocks); + return ret; +} diff --git a/tracecmd/trace-stat.c b/tracecmd/trace-stat.c index 260d0c37..a29e0c34 100644 --- a/tracecmd/trace-stat.c +++ b/tracecmd/trace-stat.c @@ -736,33 +736,18 @@ static void report_buffers(struct buffer_instance *instance) static void report_clock(struct buffer_instance *instance) { - char *str; - char *cont; char *clock; - str = get_instance_file_content(instance, "trace_clock"); - if (!str) - return; - - clock = strstr(str, "["); - if (!clock) - goto out; - clock++; - - cont = strstr(clock, "]"); - if (!cont) /* should never happen */ - goto out; - - *cont = '\0'; + if (instance) + clock = tracefs_get_clock(instance->tracefs); + else + clock = tracefs_get_clock(NULL); /* Default clock is "local", only show others */ - if (strcmp(clock, "local") == 0) - goto out; + if (clock && !strcmp(clock, "local") == 0) + printf("\nClock: %s\n", clock); - printf("\nClock: %s\n", clock); - - out: - free(str); + free(clock); } static void report_cpumask(struct buffer_instance *instance) -- 2.26.2