I didn't apply the first patch, and nothing broke up until this patch. On Tue, 29 Sep 2020 16:41:16 +0300 "Yordan Karadzhov (VMware)" <y.karadz@xxxxxxxxx> wrote: > Unfortunately this integration can only happen in a single change, > which results into one huge patch, that may be hard to review. In > this patch we modify the API itself plus the two most basic examples > demonstrating how to use it. The most noticeable change that this > new version of the API brings is that the processing of the > trace-cmd/Ftrace data is wrapped inside the dedicated implementation > of the Data stream interface and no trace-cmd definitions are leaking > outside of src/libkshark-tepdata.c. I find it hard to believe that we can't break this up more. Can you tell me what the old API did and what the new API does. I can probably help out in taking steps to go from one to the other. But I don't understand what exactly is changing without spending several days staring at this code. -- Steve
|