On Tue, Jul 14, 2020 at 3:07 PM Namhyung Kim <namhyung@xxxxxxxxxx> wrote: > > Hello, > > On Tue, Jul 14, 2020 at 7:30 PM Tzvetomir Stoyanov (VMware) > <tz.stoyanov@xxxxxxxxx> wrote: > > > > Fixes in libtraceeevnt, suggested by Namhyung Kim <namhyung@xxxxxxxxxx> > > > > Tzvetomir Stoyanov (VMware) (8): > > trace-cmd: Document tep_load_plugins_hook() > > trace-cmd: Handle strdup() error in parse_option_name() > > trace-cmd: Fix typo in tep_plugin_add_option() description > > trace-cmd: Improve error handling of tep_plugin_add_option() API > > trace-cmd: Fixed broken indentation in parse_ip4_print_args() > > trace-cmd: Fixed type in PRINT_FMT_STING > > trace-cmd: Fixed description of tep_add_plugin_path() API > > trace-cmd: Handle possible strdup() error in tep_add_plugin_path() API > > Shouldn't the prefix be libtraceevent ? Other than that, I decided to address the comments in trace-cmd repo first, and after that to backport the patches to the kernel's libtraceevent. That's why the prefix is trace-cmd. Thanks for making such a detailed review, Namhyung ! > > Acked-by: Namhyung Kim <namhyung@xxxxxxxxxx> > > Thanks > Namhyung > > > > > lib/traceevent/event-parse-local.h | 2 +- > > lib/traceevent/event-parse.c | 10 +++--- > > lib/traceevent/event-plugin.c | 50 ++++++++++++++++++++++-------- > > 3 files changed, 43 insertions(+), 19 deletions(-) > > > > -- > > 2.26.2 > > -- Tzvetomir (Ceco) Stoyanov VMware Open Source Technology Center
|