On Mon, 4 May 2020, Steven Rostedt wrote: > On Fri, 24 Apr 2020 16:25:42 +0300 > "Yordan Karadzhov (VMware)" <y.karadz@xxxxxxxxx> wrote: > > > Example: > > kernelshark -i mytrace.dat --cpu '1 4-7' --pid 11 > > Can we change this to use a comma instead of a space. Then we don't need to > worry about quotes. This seems like a good idea. I was away from it a few days, and my first intuition was to use a comma. julia > > kernelshark -i mytrace.dat --cpu 1,4-7 > > That's the common format for other unix command lines. See taskset for > instance. > > -- Steve > > > > > > This will show CPUs: 1, 4, 5, 6, 7 and task(PID): 11. > > > > Signed-off-by: Yordan Karadzhov (VMware) <y.karadz@xxxxxxxxx> > > Suggested-by: Julia Lawall <julia.lawall@xxxxxxxx> > > --- > > kernel-shark/src/KsUtils.cpp | 24 ++++++++++++++++++++++++ > > kernel-shark/src/KsUtils.hpp | 2 ++ > > kernel-shark/src/kernelshark.cpp | 32 +++++++++++++++++++++++++++++--- > > 3 files changed, 55 insertions(+), 3 deletions(-) > > > > >
|