Re: [PATCH v2 1/3] kernel-shark: Simplify the search methods in class KsTraceViewer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon,  4 May 2020 20:43:40 +0300
"Yordan Karadzhov (VMware)" <y.karadz@xxxxxxxxx> wrote:

> +++ b/kernel-shark/src/KsTraceViewer.hpp
> @@ -132,8 +132,9 @@ private:
>  
>  	size_t _searchItems();
>  
> -	void _searchItemsMapReduce(int column, const QString &searchText,
> -				   search_condition_func cond);
> +	void _searchItemsST() {_proxyModel.search(&_searchFSM, &_matchList);}
> +
> +	void _searchItemsMT();
>  
>  	void _searchEditText(const QString &);

I'll pull this in as-is, but the above should definitely have comments
stating one is "Single threaded" and the other is  "Multi threaded",
otherwise who would know what they mean?

-- Steve



[Index of Archives]     [Linux USB Development]     [Linux USB Development]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux