After applying this patch, my recordings stopped working. That's because I'm still using fifos. I found the reason for this below. On Thu, 27 Feb 2020 16:19:59 +0200 "Tzvetomir Stoyanov (VMware)" <tz.stoyanov@xxxxxxxxx> wrote: > @@ -940,7 +1215,11 @@ static int make_trace_resp(struct tracecmd_msg *msg, int page_size, int nr_cpus, > write_uints(msg->buf, data_size, ports, nr_cpus); > > msg->hdr.size = htonl(ntohl(msg->hdr.size) + data_size); > - msg->trace_resp.flags = use_fifos ? htonl(MSG_TRACE_USE_FIFOS) : htonl(0); > + msg->trace_req.flags = use_fifos ? htonl(MSG_TRACE_USE_FIFOS) : htonl(0); > + msg->trace_resp.flags = htonl(msg->trace_resp.flags); The above is what broke. That should be: msg->trace_resp.flags = use_fifos ? MSG_TRACE_USE_FIFOS : 0; msg->trace_resp.flags = htonl(msg->trace_resp.flags); -- Steve > + msg->trace_resp.tsync_proto = htonl(tsync_proto); > + msg->trace_resp.tsync_port = htonl(tsync_port); > + > msg->trace_resp.cpus = htonl(nr_cpus); > msg->trace_resp.page_size = htonl(page_size); > msg->trace_resp.trace_id = htonll(trace_id);
|