On Tue, Feb 4, 2020 at 6:42 AM Lukas Bulwahn <lukas.bulwahn@xxxxxxxxx> wrote: > > > > On Mon, 3 Feb 2020, Andy Shevchenko wrote: > > > On Sat, Feb 1, 2020 at 6:21 PM Lukas Bulwahn <lukas.bulwahn@xxxxxxxxx> wrote: > > > > > > The git history shows that the files under ./tools/lib/traceevent/ are > > > being developed and maintained by Tzetomir Stoyanov and Steven Rostedt > > > and are discussed on the linux-trace-devel list. > > > > > > Add a suitable section in MAINTAINERS for patches to reach them. > > > > > > This was identified with a small script that finds all files only > > > belonging to "THE REST" according to the current MAINTAINERS file, and I > > > acted upon its output. > > > > > +TRACE EVENT LIBRARY > > > +M: Tzvetomir Stoyanov <tz.stoyanov@xxxxxxxxx> > > > +M: Steven Rostedt <rostedt@xxxxxxxxxxx> > > > +L: linux-trace-devel@xxxxxxxxxxxxxxx > > > +S: Maintained > > > +F: tools/lib/traceevent/ > > > > Don't forget to run early mentioned scripts (in some other threads). > > > > Andy, I did run on next-20200203: Awesome, thanks! > $ ./scripts/checkpatch.pl -f MAINTAINERS > > WARNING: MAINTAINERS entries use one tab after TYPE: > #14607: FILE: MAINTAINERS:14607: > +M: Micah Morton <mortonm@xxxxxxxxxxxx> > > WARNING: MAINTAINERS entries use one tab after TYPE: > #14608: FILE: MAINTAINERS:14608: > +S: Supported > > WARNING: MAINTAINERS entries use one tab after TYPE: > #14609: FILE: MAINTAINERS:14609: > +F: security/safesetid/ > > WARNING: MAINTAINERS entries use one tab after TYPE: > #14610: FILE: MAINTAINERS:14610: > +F: Documentation/admin-guide/LSM/SafeSetID.rst > > total: 0 errors, 4 warnings, 18577 lines checked > > > That issue in MAINTAINERS has a pending patch since 2019-12-07, with three > attempts of asking to be picked up by now: > > - https://lore.kernel.org/lkml/20191207182751.14249-1-lukas.bulwahn@xxxxxxxxx/ > - https://lore.kernel.org/lkml/20200116185844.11201-1-lukas.bulwahn@xxxxxxxxx/ > - https://lore.kernel.org/lkml/20200204040434.7173-1-lukas.bulwahn@xxxxxxxxx/ > > It is not related to this patch in MAINTAINERS here. > > > I also ran $ perl ./scripts/parse-maintainers.pl and checked the generated > diff for this entry, but there was no reordering required; a one-element > list of F: entries is difficult to get unsorted ;) > > I am not adding any mess (ordering issues) to MAINTAINERS with this patch, > other than what is already there, but cleaning that up is completely other > story. -- With Best Regards, Andy Shevchenko