Re: [PATCH v3 5/5] trace-cmd: Unit test for libtracefs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 17 Jan 2020 15:55:44 +0200
"Tzvetomir Stoyanov (VMware)" <tz.stoyanov@xxxxxxxxx> wrote:

> The CUnit test infrastructure is integrated in trace-cmd.
>  http://cunit.sourceforge.net/
> The library and its headers must be installed on the machine, in order
> to build the trace-cmd unit tests. For Fedora, these packages must be installed:
>    CUnit, CUnit-devel
> 
> A new directory is added:
>  lib/utest

After running these patches through my test suite, if nothing goes
wrong I plan on applying them all but this one. My only issue with this
patch is the location of utest. Why pick lib? It probably should be a
top level directory itself. It's not going to be a library, is it?

-- Steve


> containing unit tests implementation.
> 
> Added new target to trace-cmd top Makefile:
>   make test
> which builds the unit test binary:
>  lib/utest/trace-utest
> 
> The goal of this patch is not to provide full unit test coverage of
> libtracefs, but to be a POC for adding test infrastructure to trace-cmd.
> 
> The first API, covered be the test is:
>   tracefs_iterate_raw_events()
> 
> Signed-off-by: Tzvetomir Stoyanov (VMware) <tz.stoyanov@xxxxxxxxx>
> ---



[Index of Archives]     [Linux USB Development]     [Linux USB Development]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux