On Fri, Dec 20, 2019 at 3:50 PM Steven Rostedt <rostedt@xxxxxxxxxxx> wrote: > > On Tue, 3 Dec 2019 12:35:07 +0200 > "Tzvetomir Stoyanov (VMware)" <tz.stoyanov@xxxxxxxxx> wrote: > > > From: Tzvetomir Stoyanov <tstoyanov@xxxxxxxxxx> > > > > Implementations of htonll() and ntohll() are added as > > macros, if they are not already defined. > > I'm somewhat nervous about this being in a global header, as it is > mostly generic. I wonder if we should prefix these with "tracecmd_" > just to avoid any name collisions. > > We could update this later when we make trace-cmd into a library. > I can move them to trace-msg.c file, as these are used only there. Note that a lot of clean-ups are required for libtracecmd. > -- Steve > > > > > > Signed-off-by: Tzvetomir Stoyanov <tstoyanov@xxxxxxxxxx> > > --- > > include/trace-cmd/trace-msg.h | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/include/trace-cmd/trace-msg.h b/include/trace-cmd/trace-msg.h > > index aab8a69..654ca43 100644 > > --- a/include/trace-cmd/trace-msg.h > > +++ b/include/trace-cmd/trace-msg.h > > @@ -12,4 +12,14 @@ > > > > extern unsigned int page_size; > > > > +#ifndef htonll > > +# if __BYTE_ORDER == __LITTLE_ENDIAN > > +#define htonll(x) __bswap_64(x) > > +#define ntohll(x) __bswap_64(x) > > +#else > > +#define htonll(x) (x) > > +#define ntohll(x) (x) > > +#endif > > +#endif > > + > > #endif /* _TRACE_MSG_H_ */ > -- Tzvetomir (Ceco) Stoyanov VMware Open Source Technology Center
|