On Thu, 19 Dec 2019 18:31:51 -0500 Steven Rostedt <rostedt@xxxxxxxxxxx> wrote: > On Wed, 18 Dec 2019 08:44:25 +0100 > Sven Schnelle <svens@xxxxxxxxxxxxx> wrote: > > > test.d/ftrace/func-filter-glob.tc is failing on s390 because it has > > ARCH_INLINE_SPIN_LOCK and friends set to 'y'. So the usual > > __raw_spin_lock symbol isn't in the ftrace function list. Change > > '*aw*lock' to '*time*ns' which would hopefully match some of the > > ktime_() functions on all platforms. > > This requires an ack from Masami, and this patch can go through Shuah's > tree. > > Also, any patches for the Linux kernel should be Cc'd to lkml. The > linux-trace-devel is mostly for tracing tools, not kernel patches. Thanks Steve to CC to me. BTW, are there any reason why we use different symbols for different glob patterns? I mean we can use 'schedul*', '*chedule' and '*sch*ule' as test glob patterns. Thank you, > > -- Steve > > > > > Signed-off-by: Sven Schnelle <svens@xxxxxxxxxxxxx> > > --- > > .../testing/selftests/ftrace/test.d/ftrace/func-filter-glob.tc | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-glob.tc b/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-glob.tc > > index 27a54a17da65..a5d61667cd56 100644 > > --- a/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-glob.tc > > +++ b/tools/testing/selftests/ftrace/test.d/ftrace/func-filter-glob.tc > > @@ -30,7 +30,7 @@ ftrace_filter_check '*schedule*' '^.*schedule.*$' > > ftrace_filter_check 'schedule*' '^schedule.*$' > > > > # filter by *mid*end > > -ftrace_filter_check '*aw*lock' '.*aw.*lock$' > > +ftrace_filter_check '*time*ns' '.*time.*ns$' > > > > # filter by start*mid* > > ftrace_filter_check 'mutex*try*' '^mutex.*try.*' > -- Masami Hiramatsu <mhiramat@xxxxxxxxxx>
|