Re: [PATCH v17 15/18] trace-cmd: Refactor few trace-cmd internal functions.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue,  3 Dec 2019 12:35:19 +0200
"Tzvetomir Stoyanov (VMware)" <tz.stoyanov@xxxxxxxxx> wrote:

> In order to reuse code inside trace-cmd application context,
> few functions are made non static:
> 	int make_vsock(unsigned int port);
> 	int get_vsock_port(int sd, unsigned int *port);
> 	int open_vsock(unsigned int cid, unsigned int port);
> 	char *get_guest_file(const char *file, const char *guest);

We should probably rename them to have a "trace_" prefix. This way we
know what functions are not static, but "trace_" means it's local,
where as "tracecmd_" means its exported.

-- Steve

> 
> Signed-off-by: Tzvetomir Stoyanov (VMware) <tz.stoyanov@xxxxxxxxx>
> ---



[Index of Archives]     [Linux USB Development]     [Linux USB Development]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux