On Tue, 3 Dec 2019 12:35:12 +0200
"Tzvetomir Stoyanov (VMware)" <tz.stoyanov@xxxxxxxxx> wrote:
> @@ -1046,6 +1083,57 @@ int tracecmd_write_options(struct tracecmd_output *handle)
> return 0;
> }
>
> +int tracecmd_append_options(struct tracecmd_output *handle)
> +{
> + struct tracecmd_option *options;
> + unsigned short option;
> + unsigned short endian2;
> + unsigned int endian4;
> + off_t offset;
> + int r;
> +
> + /* If already written, ignore */
> + if (handle->options_written)
> + return 0;
> +
> + if (lseek64(handle->fd, 0, SEEK_END) == (off_t)-1)
> + return -1;
> + offset = lseek64(handle->fd, -2, SEEK_CUR);
> + if (offset == (off_t)-1)
> + return -1;
> +
> + r = pread(handle->fd, &option, 2, offset);
> + if (r != 2 || option != TRACECMD_OPTION_DONE)
> + return -1;
> +
> + list_for_each_entry(options, &handle->options, list) {
> + endian2 = convert_endian_2(handle, options->id);
> + if (do_write_check(handle, &endian2, 2))
> + return -1;
> +
> + endian4 = convert_endian_4(handle, options->size);
> + if (do_write_check(handle, &endian4, 4))
> + return -1;
> +
> + /* Save the data location in case it needs to be updated */
> + options->offset = lseek64(handle->fd, 0, SEEK_CUR);
> +
> + if (do_write_check(handle, options->data,
> + options->size))
> + return -1;
> + }
> +
> + option = TRACECMD_OPTION_DONE;
> +
> + if (do_write_check(handle, &option, 2))
> + return -1;
> +
> + handle->options_written = 1;
> + handle->options_written = 1;
I think I'm seeing double.
-- Steve
> +
> + return 0;
> +}
> +
> int tracecmd_update_option(struct tracecmd_output *handle,
> struct tracecmd_option *option, int size,
> const void *data)
|