Em Mon, Dec 02, 2019 at 05:53:07PM -0500, Steven Rostedt escreveu: > On Mon, 2 Dec 2019 12:40:49 +0000 > Sudip Mukherjee <sudipm.mukherjee@xxxxxxxxx> wrote: > > > Hi Steve, > > > > On Fri, Nov 15, 2019 at 11:36 AM Sudip Mukherjee > > <sudipm.mukherjee@xxxxxxxxx> wrote: > > > > > > When we use 'O=' with make to build libtraceevent in a separate folder > > > it fails to install libtraceevent.a and libtraceevent.so.1.1.0 with the > > > error: > > > INSTALL /home/sudip/linux/obj-trace/libtraceevent.a > > > INSTALL /home/sudip/linux/obj-trace/libtraceevent.so.1.1.0 > > > cp: cannot stat 'libtraceevent.a': No such file or directory > > > Makefile:225: recipe for target 'install_lib' failed > > > make: *** [install_lib] Error 1 > > > > > > I used the command: > > > make O=../../../obj-trace DESTDIR=~/test prefix==/usr install > > > > > > It turns out libtraceevent Makefile, even though it builds in a separate > > > folder, searches for libtraceevent.a and libtraceevent.so.1.1.0 in its > > > source folder. > > > So, add the 'OUTPUT' prefix to the source path so that 'make' looks for > > > the files in the correct place. > > > > > > Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@xxxxxxxxx> > > > --- > > > tools/lib/traceevent/Makefile | 1 + > > > > A gentle ping. > > I know its the merge window now. But your ack for these two patches will allow > > me to start with the debian workflow. > > > > Thanks for the reminder. Yeah, these look fine, and I just tested them > out. > > Arnaldo, can you take these in, and possibly get them into this merge > window? > > Reviewed-by: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx> Sure, - Arnaldo
|