Re: [PATCH v12 3/9] trace-cmd: Fix tracecmd_read_page_record() to read more than one event

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 28 Aug 2019 11:57:40 +0300
"Tzvetomir Stoyanov (VMware)" <tz.stoyanov@xxxxxxxxx> wrote:

> From: Tzvetomir Stoyanov <tstoyanov@xxxxxxxxxx>
> 
> The kbuffer_next_event() will return the next event on the sub buffer.
> If we pass in the last_record to tracecmd_read_page_record(), it
> initializes the sub buffer, and by calling kbuffer_next_event()
> (instead of kbuffer_read_event()), the second event on the sub buffer
> is returned. This causes the match of the last_record not to match if
> the last_record happens to be the first event on the sub buffer.

Bah, I see why this was done incorrectly. Good catch.

This should be added independent of this series.

Thanks!

-- Steve



[Index of Archives]     [Linux USB Development]     [Linux USB Development]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux