Do not save the settings if KernelShark is running with Root privileges.
Otherwise the configuration file will be owned by Root and later the
normal user will have no access to it.
Signed-off-by: Yordan Karadzhov (VMware) <y.karadz@xxxxxxxxx>
---
kernel-shark/src/KsMainWindow.cpp | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/kernel-shark/src/KsMainWindow.cpp b/kernel-shark/src/KsMainWindow.cpp
index 3402764..6da8670 100644
--- a/kernel-shark/src/KsMainWindow.cpp
+++ b/kernel-shark/src/KsMainWindow.cpp
@@ -152,9 +152,15 @@ KsMainWindow::~KsMainWindow()
_session.getConfDocPtr());
}
- _settings.setValue("dataPath", _lastDataFilePath);
- _settings.setValue("confPath", _lastConfFilePath);
- _settings.setValue("pluginPath", _lastPluginFilePath);
+ /*
+ * Do not save the settings if KernelShark is running with Root
+ * privileges. Otherwise the configuration file will be owned by Root.
+ */
+ if (geteuid() != 0) {
+ _settings.setValue("dataPath", _lastDataFilePath);
+ _settings.setValue("confPath", _lastConfFilePath);
+ _settings.setValue("pluginPath", _lastPluginFilePath);
+ }
_data.clear();
--
2.20.1
|