Re: [PATCH v2 1/5] kernel-shark: Show warning message when running as Root

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 19.09.19 г. 23:32 ч., Steven Rostedt wrote:
On Tue, 27 Aug 2019 18:22:53 -0400
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

On Mon, 26 Aug 2019 18:58:07 +0300
"Yordan Karadzhov (VMware)" <y.karadz@xxxxxxxxx> wrote:

+	warn.setText("KernelShark will have Root privileges.");
+	warn.setInformativeText("Continue on your own risk.");

This wasn't updated.

  From: https://lore.kernel.org/linux-trace-devel/20190809091914.75f553b2@xxxxxxxxxxxxxxxxxx/

+	QMessageBox warn;
+	warn.setText("KernelShark will have Root privileges.");
+	warn.setInformativeText("Continue on your one risk.");

Probably better to say:

   "KernelShark is running with Root privileges."
   "Continue at your own risk."

I could update the patch if you like, instead of sending out another
series. Let me finish the rest of the series.


We decided in our meeting that you were going to send a v3, right? Just
want to make sure (too many things to keep track of ;-)

Yes, I am sending v3 right now.
Y.


Thanks!

-- Steve




[Index of Archives]     [Linux USB Development]     [Linux USB Development]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux