Re: [PATCH v7 01/13] tools lib traceevent: Convert remaining %p[fF] users to %p[sS]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH v7 01/13] tools lib traceevent: Convert remaining %p[fF] users to %p[sS]
- From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
- Date: Wed, 18 Sep 2019 18:22:17 +0300
- Cc: Petr Mladek <pmladek@xxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, rafael@xxxxxxxxxx, linux-acpi@xxxxxxxxxxxxxxx, devicetree@xxxxxxxxxxxxxxx, Rob Herring <robh@xxxxxxxxxx>, Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>, Joe Perches <joe@xxxxxxxxxxx>, Steven Rostedt <rostedt@xxxxxxxxxxx>, Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>, Tzvetomir Stoyanov <tstoyanov@xxxxxxxxxx>, linux-trace-devel@xxxxxxxxxxxxxxx, Jiri Olsa <jolsa@xxxxxxxxxx>, Namhyung Kim <namhyung@xxxxxxxxxx>
- In-reply-to: <20190918133419.7969-2-sakari.ailus@linux.intel.com>
- Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
- References: <20190918133419.7969-1-sakari.ailus@linux.intel.com> <20190918133419.7969-2-sakari.ailus@linux.intel.com>
- User-agent: Mutt/1.10.1 (2018-07-13)
On Wed, Sep 18, 2019 at 04:34:07PM +0300, Sakari Ailus wrote:
> There are no in-kernel %p[fF] users left. Convert the traceevent tool,
> too, to align with the kernel.
> function. The _tep_ argument is the trace event parser context. The _name_ is
> -the name of the function, the string is copied internally. The _addr_ is
> -the start address of the function. The _mod_ is the kernel module
> -the function may be in (NULL for none).
> +the name of the function, the string is copied internally. The _addr_ is the
> +start address of the function. The _mod_ is the kernel module the function may
> +be in (NULL for none).
I think this is unneeded churn (reformating string). But since maintainer Acked
this, I don't care much. But think about burden to the Git index in million of
instances around the world.
--
With Best Regards,
Andy Shevchenko
[Index of Archives]
[Linux USB Development]
[Linux USB Development]
[Linux Audio Users]
[Yosemite Hiking]
[Linux Kernel]
[Linux SCSI]