Re: [PATCH v6 01/12] tools lib traceevent: Convert remaining %p[fF] users to %p[sS]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH v6 01/12] tools lib traceevent: Convert remaining %p[fF] users to %p[sS]
- From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
- Date: Tue, 10 Sep 2019 12:22:33 +0300
- Cc: Petr Mladek <pmladek@xxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, rafael@xxxxxxxxxx, linux-acpi@xxxxxxxxxxxxxxx, devicetree@xxxxxxxxxxxxxxx, Rob Herring <robh@xxxxxxxxxx>, Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>, Joe Perches <joe@xxxxxxxxxxx>, Steven Rostedt <rostedt@xxxxxxxxxxx>, Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>, Tzvetomir Stoyanov <tstoyanov@xxxxxxxxxx>, linux-trace-devel@xxxxxxxxxxxxxxx, Jiri Olsa <jolsa@xxxxxxxxxx>, Namhyung Kim <namhyung@xxxxxxxxxx>
- In-reply-to: <20190910084707.18380-2-sakari.ailus@linux.intel.com>
- Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
- References: <20190910084707.18380-1-sakari.ailus@linux.intel.com> <20190910084707.18380-2-sakari.ailus@linux.intel.com>
- User-agent: Mutt/1.10.1 (2018-07-13)
On Tue, Sep 10, 2019 at 11:46:56AM +0300, Sakari Ailus wrote:
> There are no in-kernel %p[fF] users left. Convert the traceevent tool,
> too, to align with the kernel.
> function. The _tep_ argument is the trace event parser context. The _name_ is
> -the name of the function, the string is copied internally. The _addr_ is
> -the start address of the function. The _mod_ is the kernel module
> -the function may be in (NULL for none).
> +the name of the function, the string is copied internally. The _addr_ is the
> +start address of the function. The _mod_ is the kernel module the function may
> +be in (NULL for none).
This seems a churn of reformatting.
> - if (asprintf(&format, "%%pf: (NO FORMAT FOUND at %llx)\n", addr) < 0)
> + if (asprintf(&format, "%%ps: (NO FORMAT FOUND at %llx)\n",
> + addr) < 0)
Splitting line also seems a churn to me. But this one is up to maintainers.
Other than above, looks good to me, thanks!
--
With Best Regards,
Andy Shevchenko
[Index of Archives]
[Linux USB Development]
[Linux USB Development]
[Linux Audio Users]
[Yosemite Hiking]
[Linux Kernel]
[Linux SCSI]