On Fri, 26 Jul 2019 13:55:44 -0700
Andres Freund <andres@xxxxxxxxxxx> wrote:
> How about my proposal to instead change the loops in
> trace-event-{python,perl}.c, the only callers of trace_find_next_event,
> to be something akin to
>
> [idx_type_for_tep_get_event] event_count = tep_get_events_count(pevent);
> for ([idx_type_for_tep_get_event] idx = 0; idx < event_count; idx++)
> {
> struct tep_event *event = tep_get_events(...);
>
> }
>
> and just removing trace_find_next_event()? It's not a nice API imo, and
> seems unnecessary given that the events aren't a linked list anymore.
Yep, go for it :-)
>
>
> > Care to send a formal patch?
>
> Will do.
Thanks!
-- Steve
|