Re: [PATCH 1/2] kernel-shark: Initialize the data-related fields of the model

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 17.07.19 г. 16:28 ч., Steven Rostedt wrote:
On Wed, 17 Jul 2019 15:42:31 +0300
"Yordan Karadzhov (VMware)" <y.karadz@xxxxxxxxx> wrote:

Are we just trying to set all fields of histo to NULL or zero? If so,
why not just do:

	memset(histo, 0, sizeof(*histo));

?

This will make sure ksmodel_init() zeros all of histo when/if we add new
fields.

Yes, this will do a better job.

Care to send a v2 patch?

Just make the change and apply, if this is OK with you.

Thanks a lot!
Yordan


Thanks Yordan!

-- Steve




[Index of Archives]     [Linux USB Development]     [Linux USB Development]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux