Re: [PATCH v3] kernel-shark: Define a CMAKE_BUILD_TYPE "Package"

Steven Rostedt <rostedt@xxxxxxxxxxx> · Mon, 8 Jul 2019 09:26:32 -0400

On Mon,  8 Jul 2019 12:19:45 +0300
"Yordan Karadzhov (VMware)" <y.karadz@xxxxxxxxx> wrote:

> From: Yordan Karadzhov <ykaradzhov@xxxxxxxxxx>
> 
> A special build type dedicated for package maintainers is added.
> By default this build type adds the "-O3" compiler flag. Users
> can chose their own compiler flags by providing the corresponding
> CMAKE_XXXX_FLAGS_PACKAGE Command-Line options.
> 
> If no types is specified, the build type will be "Debug".
> 
> Signed-off-by: Yordan Karadzhov <ykaradzhov@xxxxxxxxxx>
> 

Thanks Yordan!

I applied and pushed most your patches upstream.

I started to play a little with the record feature, and found some
issues.

 1) It still adds a -e'event' for all events when a system is selected.
    Can we just make it use the system? -eirq instead of
    -eirq:irq_handler_entry -eirq:irq_handler_exit -eirq...

 2) When I executed it, it gave me an error, and then crashed
    kernelshark. It should check the status of the run before it tries
    to reload it.

 3) I saved the report as the recorder was still running (but
    kernelshark crashed). And then when I loaded the report (attached)
    it just executed it. The "import" should just pull it in and load
    the settings. This way, one could make updates to a default saved
    record.

These probably should be fixed before ks1.0 is released.

Thanks!

-- Steve