Re: [PATCH v2 3/3] kernel-shark: Define a CMAKE_BUILD_TYPE "Package"

"Yordan Karadzhov (VMware)" <y.karadz@xxxxxxxxx> · Mon, 8 Jul 2019 12:16:24 +0300

On 6.07.19 г. 2:34 ч., Steven Rostedt wrote:

On Fri, 14 Jun 2019 13:26:59 +0000
Yordan Karadzhov <ykaradzhov@xxxxxxxxxx> wrote:

A special build type dedicated for package maintainers is added.
By default this build type adds the "-O2" compiler flag. Users
can chose their own compiler flags by providing the corresponding
CMAKE_XXXX_FLAGS_PACKAGE Command-Line options.

If no type is specified, the build type will be "Debug".

Signed-off-by: Yordan Karadzhov <ykaradzhov@xxxxxxxxxx>

Hmm, after applying this commit, I get this:

  <trace-cmd.git># make install_gui
  <trace-cmd.git># cd
  <~/># kernelshark
kernelshark: error while loading shared libraries: libkshark-gui.so.0.9.8: cannot open shared object file: No such file or directory

Thanks!

I see my mistake. Is turns that we need to set CMAKE_INSTALL_RPATH 

regardless of the choice to build with or without RPATH. This is not 

made clear in the CMake documentation. So the line

set(CMAKE_INSTALL_RPATH "${_INSTALL_PREFIX}/lib/${KS_APP_NAME}/")

has to go outside of the IF. I will send new version of the patch.

Yordan

-- Steve