On Tue, 18 Jun 2019 13:54:30 +0300 "Yordan Karadzhov (VMware)" <y.karadz@xxxxxxxxx> wrote: > I agree with all functional changes in those patches. However, the > README file becomes a bit ambiguous. Heh, I wrote that at the last minute and was a bit tired. I was hoping for a better write up from someone ;-) > > I would prefer having something like this > > 2. Building KernelShark: > 2.1 Option 1 : build KernelShark as part of trace-cmd > > make gui > All explanations for this build option are following > ... > > 2.2 Option 2 : standalone build of KernelShark (for hackers only) > > cd kernel-shark/build > cmake ../ > make > All explanations for this build option are following ... > ... > > Note that in Option 1 > > make clean > > is equivalent to > > make clean > ./cmake_clean.sh > > in Option 2. Makes sense. Thanks! -- Steve
|