On Mon, 17 Jun 2019 16:18:38 +0300 Ceco <tz.stoyanov@xxxxxxxxx> wrote: > Hi Steven > > On Mon, Jun 17, 2019 at 4:06 PM Steven Rostedt <rostedt@xxxxxxxxxxx> wrote: > > > ... > > > > Hmm, I think this is a bit overkill. I don't really see anything using > > more than one or two data vectors. All I see would be at most a "count" > > followed by a list of data, which is what I think you are using this > > for. > > > > I rather wait to implement something like this when there's more of a > > need for it. I don't believe this change really requires it. > > > > -- Steve > > > > Actually, this patch is from the patch set (N 7): > "trace-cmd: Timetamps sync between host and guest machines, relying > on vsock events. " > and I took it as-is. In timesync changes tracecmd_add_option_v() is > used in similar way. > That explains the tracecmd_append_options() API, which is used there. > > Ah, that needed to be stated. Yeah, when taking a patch from another series, make sure that the change log is updated too. Never expect that the reviewer will know about any other series ;-) -- Steve
|