Re: [PATCH] trace-cmd: Make the version defines part of tc-version.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2019-06-12 at 08:51 -0400, Steven Rostedt wrote:
> From: "Steven Rostedt (VMware)" <rostedt@xxxxxxxxxxx>
> 
> Move the version string creations as part of the tc-version.h file,
> and have
> trace-record.c include and use that. The VERSION_STRING is already
> defined
> and obsoletes TRACECMD_VERSION. For consistency, use VERSION_GIT to
> define
> the git sha1. Also, add logic to detect if the source file is a git
> repo,
> and use "not-a-git-repo" as the sha1 if it is not found. Add a "+" to
> the
> end of the git sha1 if the repo has modifications in it.
> 
> Signed-off-by: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx>

Thanks, Steven. I completely missed tc-version.h header's existence in
the initial patch.

Reviewed-by: Slavomir Kaslev <kaslevs@xxxxxxxxxx>

Cheers,

--Slavi




[Index of Archives]     [Linux USB Development]     [Linux USB Development]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux