On Thu, 25 Apr 2019 12:34:36 -0400
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> Hi Alan,
>
> Thanks for the patch. FYI, it's best to also Cc
> linux-trace-devel@xxxxxxxxxxxxxxx when sending patches.
>
> On Thu, 25 Apr 2019 09:27:49 -0700
> Alan Mikhak <amikhak@xxxxxxxxxxxxxxxxxx> wrote:
>
> > From: Alan Mikhak <amikhak@xxxxxxxxxxxxxxxxxx>
> >
> > Resolve linker relocation error when linking libkshark.so.0.9.8
> > with cmake on armv7l, aarch64, and some x86_64 platforms.
> >
> > Ubuntu 16.04 (xenial) on x86_64:
> > relocation R_X86_64_32 against `.rodata.str1.1' can not be used when
> > making a shared object; recompile with -fPIC
> >
> > Debian 9.8 (stretch) on x86_64:
> > relocation R_X86_64_TPOFF32 against `seq' can not be used when making
> > a shared object; recompile with -fPIC
> >
> > Signed-off-by: Alan Mikhak <amikhak@xxxxxxxxxxxxxxxxxx>
> > ---
> > kernel-shark/CMakeLists.txt | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/kernel-shark/CMakeLists.txt b/kernel-shark/CMakeLists.txt
> > index 1aee858..ac17642 100644
> > --- a/kernel-shark/CMakeLists.txt
> > +++ b/kernel-shark/CMakeLists.txt
> > @@ -32,8 +32,8 @@ endif (Qt5Widgets_FOUND)
> > set(LIBRARY_OUTPUT_PATH "${KS_DIR}/lib")
> > set(EXECUTABLE_OUTPUT_PATH "${KS_DIR}/bin")
> >
> > -set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wall -g -pthread")
> > -set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -g -std=c++11 -pthread")
> > +set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wall -g -pthread -fPIC")
> > +set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -g -std=c++11 -pthread -fPIC")
>
> Yordan,
>
> Can you take a look at this patch and add a Reviewed-by tag if you are
> good with it?
This slipped through the cracks. Yordan, are you good with this?
-- Steve
>
> >
> > if(NOT _INSTALL_PREFIX)
> > set(_INSTALL_PREFIX "/usr/local")
|