Re: [PATCH v2 3/8] kernel-shark: Add logic for the plugins search path

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 4.05.19 г. 2:05 ч., Steven Rostedt wrote:
On Thu,  2 May 2019 15:40:04 +0300
Yordan Karadzhov <ykaradzhov@xxxxxxxxxx> wrote:

If the application has not been started from its installation location
and the the directory

  app_file_path + "../../kernel-shark/lib"

exists, all build-in plugins will be loaded from this directory. In any
other case all build-in plugins will be loaded from

_INSTALL_PREFIX/lib/kshark/plugins/

Suggested-by: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx>
Reviewed-by: Slavomir Kaslev <kaslevs@xxxxxxxxxx>
Signed-off-by: Yordan Karadzhov <ykaradzhov@xxxxxxxxxx>
---
  kernel-shark/src/KsUtils.cpp            | 40 ++++++++++++++++++-------
  kernel-shark/src/KsUtils.hpp            |  2 ++
  kernel-shark/src/plugins/CMakeLists.txt |  2 +-
  3 files changed, 32 insertions(+), 12 deletions(-)


Hi Yordan,

After applying this patch, kernelshark's behavior for loading trace.dat
changed. It no longer looks for the file in the current directory. If I
run:

  # trace-cmd record -e sched_switch sleep 1
  # kernelshark

It loads without loading the produced trace.dat.

If I run:

  # kernelshark trace.dat

I get an error message stating:

  "Unable to find file trace.dat"

I see the problem. Have you pushed this patch already? I can send you a corrected version of the patch or a separate patch with the fix.

Thanks!
Yordan


-- Steve




[Index of Archives]     [Linux USB Development]     [Linux USB Development]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux