Re: [PATCH] trace-cmd-listen: Fix resource leak of msg_handle

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri,  3 May 2019 16:24:49 +0200
John Kacur <jkacur@xxxxxxxxxx> wrote:

> Fix the potential resource leak of msg_handle by calling
> tracecmd_msg_handle_close before returning in an error path
> 
> Signed-off-by: John Kacur <jkacur@xxxxxxxxxx>
> ---
>  tracecmd/trace-listen.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tracecmd/trace-listen.c b/tracecmd/trace-listen.c
> index 8bd7badb50e1..3106022eeb39 100644
> --- a/tracecmd/trace-listen.c
> +++ b/tracecmd/trace-listen.c
> @@ -761,6 +761,7 @@ static int do_connection(int cfd, struct sockaddr_storage *peer_addr,
>  		plog("Error with getnameinfo: %s\n",
>  		       gai_strerror(s));
>  		close(cfd);
> +		tracecmd_msg_handle_close(msg_handle);
>  		return -1;
>  	}
>  

Applied. Thanks John!

-- Steve



[Index of Archives]     [Linux USB Development]     [Linux USB Development]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux