Re: [PATCH v2 0/4] Add trace events for SD registers.
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH v2 0/4] Add trace events for SD registers.
- From: Ulf Hansson <ulf.hansson@xxxxxxxxxx>
- Date: Tue, 23 Apr 2019 08:29:15 +0200
- Cc: "linux-mmc@xxxxxxxxxxxxxxx" <linux-mmc@xxxxxxxxxxxxxxx>, linux-trace-devel@xxxxxxxxxxxxxxx, Daniel Kurtz <djkurtz@xxxxxxxxxxxx>, zwisler@xxxxxxxxxxxx, Steven Rostedt <rostedt@xxxxxxxxxxx>, hongjiefang <hongjiefang@xxxxxxxxxxxx>, Jennifer Dahm <jennifer.dahm@xxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, Shawn Lin <shawn.lin@xxxxxxxxxxxxxx>, Kyle Roeschley <kyle.roeschley@xxxxxx>, Avri Altman <avri.altman@xxxxxxx>, Simon Horman <horms+renesas@xxxxxxxxxxxx>
- In-reply-to: <20190416183257.247902-1-rrangel@chromium.org>
- References: <20190416183257.247902-1-rrangel@chromium.org>
On Tue, 16 Apr 2019 at 20:33, Raul E Rangel <rrangel@xxxxxxxxxxxx> wrote:
>
> I am not able to make a single event class for all these registers. They
> all have different struct sizes and different printf formats.
>
> Thanks for the reviews!
>
> Changes in v2:
> - Made trace_sd_scr print out flags.
> - Add BUILD_BUG_ON to make sure tracing stays in sync with structs.
> - memcpy using sizeof(__entry->raw)
>
> Raul E Rangel (4):
> mmc: core: Add trace event for SD SCR response
> mmc: core: Add trace event for SD SSR response
> mmc: core: Add trace event for SD OCR response
> mmc: core: Add trace event for CSD response
>
> drivers/mmc/core/mmc.c | 4 +
> drivers/mmc/core/sd.c | 10 ++
> drivers/mmc/core/sd_ops.c | 6 ++
> include/trace/events/mmc.h | 204 +++++++++++++++++++++++++++++++++++++
> 4 files changed, 224 insertions(+)
>
> --
> 2.21.0.392.gf8f6787159e-goog
>
Why do you need this? We already have these card registers reflected
though sysfs files, isn't that sufficient?
Kind regards
Uffe
[Index of Archives]
[Linux USB Development]
[Linux USB Development]
[Linux Audio Users]
[Yosemite Hiking]
[Linux Kernel]
[Linux SCSI]