On Fri, 19 Apr 2019 10:43:17 +0300
Slavomir Kaslev <slavomir.kaslev@xxxxxxxxx> wrote:
> > diff --git a/kernel-shark/src/KsUtils.cpp b/kernel-shark/src/KsUtils.cpp
> > index 6af0c66..b05c0dc 100644
> > --- a/kernel-shark/src/KsUtils.cpp
> > +++ b/kernel-shark/src/KsUtils.cpp
> > @@ -423,13 +423,12 @@ void KsPluginManager::_parsePluginList()
> > */
> > void KsPluginManager::registerFromList(kshark_context *kshark_ctx)
> > {
> > - auto lamRegBuiltIn = [&kshark_ctx](const QString &plugin)
> > + auto lamRegBuiltIn = [&kshark_ctx, this](const QString &plugin)
>
> Prefixing lambda function names with 'lam' is an interesting modern
> form of Hungarian notation[1]. It's not useful for the reader or the
> compiler and it doesn't make a great style. No need to change this
> patch but having a clean up patch that does a bulk rename would be
> nice.
I don't know. Having them labeled does make it easy to know that they
are lambda functions when used later.
-- Steve
|