On Tue, 2019-04-16 at 17:48 -0400, Steven Rostedt wrote:
> On Tue, 16 Apr 2019 02:00:15 +0300
> Slavomir Kaslev <kaslevs@xxxxxxxxxx> wrote:
>
> > static char *make_pid_filter(char *curr_filter, const char *field)
> > {
> > + int curr_len = 0, last_exclude = -1;
>
> Small nit. Usually when adding multiple variables on one line like
> this, the variables should be related. Because curr_len and
> last_exclude are not related, it is best to keep them separate.
Sent v4 addressing those and added a section about --no-filter to
trace-cmd record's man page.
Cheers,
-- Slavi
|