From: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx> As return is not a function we do not need parenthesis around the return value. Also, a function returning bool does not need to add !!. Signed-off-by: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> Cc: Jiri Olsa <jolsa@xxxxxxxxxx> Cc: Namhyung Kim <namhyung@xxxxxxxxxx> Cc: Tzvetomir Stoyanov <tstoyanov@xxxxxxxxxx> Link: https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Flkml.kernel.org%2Fr%2F20190401164343.817886725%40goodmis.org&data=02%7C01%7Ctstoyanov%40vmware.com%7C420f58a3ff864e3d93b408d6b7853daf%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C636898180235384820&sdata=PTx4BKspBlUxHIPfzZRf2Rj5J8LmfzXxdCIXKdDUtoA%3D&reserved=0 Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx> --- lib/traceevent/event-parse-api.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/traceevent/event-parse-api.c b/lib/traceevent/event-parse-api.c index f2e5d18..fb49d1b 100644 --- a/lib/traceevent/event-parse-api.c +++ b/lib/traceevent/event-parse-api.c @@ -88,7 +88,7 @@ void tep_clear_flag(struct tep_handle *tep, enum tep_flag flag) bool tep_test_flag(struct tep_handle *tep, enum tep_flag flag) { if (tep) - return (tep->flags & flag); + return tep->flags & flag; return false; } @@ -367,7 +367,7 @@ int tep_get_parsing_failures(struct tep_handle *tep) bool tep_is_old_format(struct tep_handle *tep) { if (tep) - return !!(tep->old_format); + return tep->old_format; return false; } -- 2.20.1