On Tue, 26 Mar 2019 08:58:21 -0400 Steven Rostedt <rostedt@xxxxxxxxxxx> wrote: > I'm still confused. We shouldn't be looking for any paths at build time. > This should be done at run time. > > Now, we can check the local directory that kernelshark lives in. That > is, if we are running from a fresh build, at start up, we can look at > > `pwd`/../lib | `pwd`/../../plugins > > and see if those directories exist at run time. And if they do, we can > use them (as we would assume that the exec is running from a local > source tree). > > I really don't want any build artifacts in the executable. This will > mean that you need to do special arrangements to build kernelshark and > then move it to another machine. Note, I was confused as I was thinking this was about plugins and not about the dynamic runtime / static libraries. I see that this is about where to find those libraries. This is about where to find libtracecmd (soon to be libftrace). Currently that's a static library, and we want it to be a dynamic one in the future. OK, I'm fine with this patch as is and will pull it in. -- Steve
|