On Fri, 22 Mar 2019 15:07:40 +0200 Tzvetomir Stoyanov <tstoyanov@xxxxxxxxxx> wrote: > diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c > index 87494c7c619d..69af77896283 100644 > --- a/tools/lib/traceevent/event-parse.c > +++ b/tools/lib/traceevent/event-parse.c > @@ -6386,7 +6386,7 @@ int tep_get_any_field_val(struct trace_seq *s, struct tep_event *event, > * @record: The record with the field name. > * @err: print default error if failed. > * > - * Returns: 0 on success, -1 field not found, or 1 if buffer is full. > + * Returns: 1 on success, -1 field not found, or 0 if buffer is full. Does it? It returns trace_seq_printf() which returns: > 0 on succes (the length of characters written to s) 0 if the buffer is filled < 0 on error. I don't think we want to state "1" or "-1". > */ > int tep_print_num_field(struct trace_seq *s, const char *fmt, > struct tep_event *event, const char *name, > @@ -6418,7 +6418,7 @@ int tep_print_num_field(struct trace_seq *s, const char *fmt, > * @record: The record with the field name. > * @err: print default error if failed. > * > - * Returns: 0 on success, -1 field not found, or 1 if buffer is full. > + * Returns: 1 on success, -1 field not found, or 0 if buffer is full. Same here. -- Steve > */ > int tep_print_func_field(struct trace_seq *s, const char *fmt, > struct tep_event *event, const char *name,
|