On Wed, Mar 20, 2019 at 4:35 PM Steven Rostedt <rostedt@xxxxxxxxxxx> wrote: > > On Wed, 20 Mar 2019 14:14:03 +0000 > Tzvetomir Stoyanov <tstoyanov@xxxxxxxxxx> wrote: > > > > But this rmdir is not moved to tracecmd_remove_instance() — it’s lost. This looks like it’s introducing a bug. > > > > Thanks Matt, this one is from v1 of the patchset, I didn't notice it. > > I'll add the rmdir() call in the next version. > > There is some general problem with deleting instances, or (most > > probably) I cannot figure out what it the proper way > > to delete a ftrace instance - even after the call to rmdir() in > > tracecmd_remove_instance(), the instance dir is still there. > > I tried to run "rm -rf path_to_instance_dir" from the shell (at root), > > after the trace-cmd is executed, got a lot of > > "Operation not permitted" errors and the instance dir is not deleted. > > Make sure you reset the instance before trying to remove it. There's > some operations that can be started that wont let you remove the > instance until they are cleaned up. > > But if you are still having issues with that, let me know. It could be > a bug in the instance removal code in the kernel. I still get the issue, checked that the instance is set with default values. Attached is a simple script, which does the same - just run it as root > > -- Steve -- Tzvetomir (Ceco) Stoyanov VMware Open Source Technology Center
Attachment:
finstance.sh
Description: finstance.sh
|