On Mon, Mar 18, 2019 at 11:04 PM Matt Helsley <mhelsley@xxxxxxxxxx> wrote: > > > > > On Mar 8, 2019, at 5:36 AM, Tzvetomir Stoyanov <tstoyanov@xxxxxxxxxx> wrote: > > > > This patch adds initial support for libtraceevent man pages - > > Documentation directory, templates, configurations, Makefiles. > > The first man page is also part of the patch - summary of the > > library and all its APIs. Building of the documentation is > > integrated into the libtraceevent build process, new targets are > > added to its Makefile: > > make doc > > make doc-clean > > make doc-install > > make doc-uninstall > > > > Signed-off-by: Tzvetomir Stoyanov <tstoyanov@xxxxxxxxxx> > > --- > > tools/lib/traceevent/Documentation/Makefile | 205 ++++++++++++++++++ > > .../traceevent/Documentation/asciidoc.conf | 91 ++++++++ > > .../Documentation/libtraceevent.txt | 198 +++++++++++++++++ > > .../traceevent/Documentation/manpage-1.72.xsl | 14 ++ > > .../traceevent/Documentation/manpage-base.xsl | 35 +++ > > .../Documentation/manpage-bold-literal.xsl | 17 ++ > > .../Documentation/manpage-normal.xsl | 13 ++ > > .../Documentation/manpage-suppress-sp.xsl | 21 ++ > > tools/lib/traceevent/Makefile | 13 ++ > > 9 files changed, 607 insertions(+) > > create mode 100644 tools/lib/traceevent/Documentation/Makefile > > create mode 100644 tools/lib/traceevent/Documentation/asciidoc.conf > > create mode 100644 tools/lib/traceevent/Documentation/libtraceevent.txt > > create mode 100644 tools/lib/traceevent/Documentation/manpage-1.72.xsl > > create mode 100644 tools/lib/traceevent/Documentation/manpage-base.xsl > > create mode 100644 tools/lib/traceevent/Documentation/manpage-bold-literal.xsl > > create mode 100644 tools/lib/traceevent/Documentation/manpage-normal.xsl > > create mode 100644 tools/lib/traceevent/Documentation/manpage-suppress-sp.xsl > > > > <snip> > > > > diff --git a/tools/lib/traceevent/Makefile b/tools/lib/traceevent/Makefile > > index f65243137d6d..3764e003d1cc 100644 > > --- a/tools/lib/traceevent/Makefile > > +++ b/tools/lib/traceevent/Makefile > > @@ -53,6 +53,7 @@ pkgconfig_dir ?= $(word 1,$(shell $(PKG_CONFIG) \ > > > > export man_dir man_dir_SQ INSTALL > > export DESTDIR DESTDIR_SQ > > +export EVENT_PARSE_VERSION > > > > set_plugin_dir := 1 > > > > @@ -313,6 +314,18 @@ clean: > > $(RM) TRACEEVENT-CFLAGS tags TAGS; \ > > $(RM) $(PKG_CONFIG_FILE) > > > nit: I notice you’re adding new targets which should probably be added to PHONY. e.g.: > > PHONY += doc > > +doc: > > + $(call descend,Documentation) > > + > > PHONY += doc-clean > > +doc-clean: > > + $(call descend,Documentation,clean) > > + > > PHONY += doc-install > > +doc-install: > > + $(call descend,Documentation,install) > > + > > +doc-uninstall: > > + $(call descend,Documentation,uninstall) > > + > > Reviewed-by: Matt Helsley <mhelsley@xxxxxxxxxx> Thanks Matt, I'll add it in the next version of the patch. -- Tzvetomir (Ceco) Stoyanov VMware Open Source Technology Center
|