On Mon, 18 Mar 2019 14:47:09 -0400
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> On Wed, 13 Mar 2019 11:42:35 -0700
> Patrick McLean <chutzpah@xxxxxxxxxx> wrote:
>
> > On Wed, 13 Mar 2019 17:22:18 +0200
> > Yordan Karadzhov <ykaradzhov@xxxxxxxxxx> wrote:
> >
> > > The CMAKE build system of KernelShark performs automated search
> > > for the trace-cmd libraries, headers and executable before
> > > building the GUI. The new order of the list of directories to
> > > search in is the following:
> > >
> > > 1. ${TRACE_CMD}/ ($TRACE_CMD is an environment variable)
> > >
> > > 2. CMAKE_SOURCE_DIR/../
> > >
> > > 3. Platform / system specific locations
> > >
> >
> > For system installs (especially when trace-cmd and trace-cmd are
> > separate packages), it's nicer to have trace-cmd install a pkgconfig
> > file. Then the kernelshark can cmake use pkgconfig for getting the
> > build options to find the headers, libraries, and binaries.
> >
> > See https://people.freedesktop.org/~dbn/pkg-config-guide.html for
> > documentation on pkgconfig and pkgconfig files.
>
> Patrick,
>
> Are you OK if I pull these patches in for now, and we sort out the
> configurations later? I was holding this off, but found that some of
> Yordan's other patches are dependent on this.
>
That's fine, my suggestions are more for long-term than an immediate
need. Most distros will probably work with the generic locations anyway.
|