Re: [PATCH v4 15/46] tools/lib/traceevent: Man pages for tep_register_function() and tep_register_print_string()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri,  8 Mar 2019 15:36:23 +0200
Tzvetomir Stoyanov <tstoyanov@xxxxxxxxxx> wrote:

> +EXAMPLE
> +-------
> +[source,c]
> +--
> +#include <event-parse.h>
> +...
> +struct tep_handle *tep = tep_alloc();
> +...
> +	if (tep_register_function(tep, "my_custom_func",
> +			  	 (unsigned long long) 0x12345678, NULL) != 0) {

There's a whitespace bug in the above string.

Also, I wouldn't use "my_custom_func" as the example name, as its not
for custom names. I would use "kernel_function_X" or something similar.

-- Steve

> +		/* Failed to register my_custom_func address mapping */
> +	}
> +...
> +	if (tep_register_print_string(tep, "print string",
> +			  	 (unsigned long long) 0x87654321, NULL) != 0) {
> +		/* Failed to register "print string" address mapping */
> +	}
> +--



[Index of Archives]     [Linux USB Development]     [Linux USB Development]     [Linux Audio Users]     [Yosemite Hiking]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux